This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
[NSE-732]Adding new config to enable/disable complex data type support #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
zhouyuan
commented
Mar 21, 2022
| @@ -86,7 +89,11 @@ case class ColumnarShuffleExchangeExec( | |||
| // check input datatype | |||
| for (attr <- child.output) { | |||
| try { | |||
| ConverterUtils.createArrowField(attr) | |||
| if (!columnarConf.enableComplexType) { | |||
| ConverterUtils.checkIfTypeSupported(attr.dataType) | |||
There was a problem hiding this comment.
@zhixingheyi-tian can you please also check if this make sense to you? This helps to easily disable(fallback) on complex type
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
zhouyuan
force-pushed
the
wip_config_complextype
branch
from
0f219aa
to
8eb22c7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Adding new config to enable/disable complex data type support
Signed-off-by: Yuan Zhou yuan.zhou@intel.com
How was this patch tested?
pass jenkins